Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: Patch against 1.7.4

Project highlights: Stable Version: 1.6.1, Development Version: 1.7.6

current
Discussion topic

Back to topic list

Re: Patch against 1.7.4

Reply

Author theslack
Full name Jack Neely
Date 2006-08-11 06:31:08 PDT
Message Pauline,

Umm...I think you forgot to include the users.py file. :-)

Jack

On 8/11/06, Pauline Middelink <middelink at polyware dot nl> wrote:
> Hi Jack,
>
> Attached a patch for 1.7.4. I tried to add some user handeling to
> current.
>
> In essence it creates a USER table, with for now only a user_id,
> username and password. During registration up2date will check
> if the user/passwd already exists, and if not make a new user for
> it. This works. Then the patch adds a user_id to the profiles,
> making the systems 'owned' by the user. This seems to work in
> my little testcases ok.
>
> Second thing the patch does is implement functionality for the
> add/del/update package list which is maintained my up2date/rhn_check.
> It uses the INSTALLED database, which has been changed to include
> name,version,release and epoch fields. In my opinion there was
> a thinko in the previous design, it assumed all the packages the
> client has installed could be matched to a package_id. Does not
> work in the real-world :). So the package_id became optional.
> The patch tries to maintain a mapping from the INSTALLED.nvre
> tuple to the current PACKAGE list (during deleteRPMS and addPackage).
> Thus, for the packages which ARE known to current, the
> INSTALLED.package_id is/should be correct.
>
> !!!
> Something you might want to look at (python is not my native
> language) is the way I handle the two types of tuples add_package
> needs to process. During registration the tuple contains a arch
> and a cookie, but in later updates on these two fields are missing.
> I used a boolean and a try/except to switch between the two. There
> might be a smarter way of handeling this.
>
> Some TODO's, which i'm willing to work on:
> - crypt/md5 the password before putting it in database or using it.
> - store hardware info in HARDWARE table. Need better format than
> current table scheme.
> - add some fields to PROFILE so we can check if the system logs
> in, and if so, how often.
> - setup a QUEUE, so we can tickle a system to resend profile etc.
> Queue itself is not difficult, all you need to do is sent a
> properly formatted (python serialized) method to the client.
> [i could invision a cadmin queue command for this :) ]
>
> Some nagging questions:
> Why is PROFILE not called SYSTEM?
> Why is INSTALLED not called SYSTEM_INSTALLED?
> Why is HARDWARE not called SYSTEM_HARDWARE?
>
> Met vriendelijke groet,
> Pauline Middelink
> --
> GPG Key fingerprint = 2D5B 87A7 DDA6 0378 5DEA BD3B 9A50 B416 E2D0 C3C2
> For more details look at my website http://www.polyware.​nl/~middelink
>
>
>

« Previous message in topic | 4 of 9 | Next message in topic »

Messages

Show all messages in topic

Patch against 1.7.4 Pauline Middelink <middelink at polyware dot nl> Pauline Middelink <middelink at polyware dot nl> 2006-08-11 03:42:51 PDT
     Re: Patch against 1.7.4 theslack Jack Neely 2006-08-11 06:20:45 PDT
         Re: Patch against 1.7.4 Pauline Middelink <middelink at polyware dot nl> Pauline Middelink <middelink at polyware dot nl> 2006-08-11 09:14:10 PDT
     Re: Patch against 1.7.4 theslack Jack Neely 2006-08-11 06:31:08 PDT
         Re: Patch against 1.7.4 Pauline Middelink <middelink at polyware dot nl> Pauline Middelink <middelink at polyware dot nl> 2006-08-11 09:00:26 PDT
         Re: Patch against 1.7.4 - update Pauline Middelink <middelink at polyware dot nl> Pauline Middelink <middelink at polyware dot nl> 2006-08-11 09:43:42 PDT
         Re: Patch against 1.7.4 Pauline Middelink <middelink at polyware dot nl> Pauline Middelink <middelink at polyware dot nl> 2006-08-11 10:18:15 PDT
             Re: Patch against 1.7.4 Pauline Middelink <middelink at polyware dot nl> Pauline Middelink <middelink at polyware dot nl> 2006-08-11 10:20:03 PDT
                 Re: Patch against 1.7.4 theslack Jack Neely 2006-08-11 10:33:02 PDT
Messages per page: