Login | Register
My pages Projects Community openCollabNet

Discussions > dev > Re: MySQL and other sql patch

Project highlights: Stable Version: 1.6.1, Development Version: 1.7.6

current
Discussion topic

Back to topic list

Re: MySQL and other sql patch

Reply

Author Hunter Matthews <thm at duke dot edu>
Full name Hunter Matthews <thm at duke dot edu>
Date 2003-07-08 09:23:08 PDT
Message On Tue, 2003-07-08 at 08:50, Frank Sweetser wrote:
> > On Mon, 07 Jul 2003, Frank Sweetser wrote:
> >
> > > I've attached a patch which adds a new db_type, 'sql'. I started out by
> > > just copying db/postgres/ and then hacked it up to work with either mysql
> > > or postgresql based on a new config var, 'db_driver'. It should still work
> > > just as before with postgresql, though I've only really tested it with
> > > mysql so far.
> > Uhhh.... no. I put the db_type variable in to distinguish
> > between backends, not add another layer. I've got no problems with the
> > concept of a MySQL backend, but it will be put in with a db_type of
> > 'mysql' or something similar, not with a completely new config variable.

I agree with John.

>
> Fair enough. With the backend api, though, this would require a lot of code
> duplication that's not db dependant. Would you object to moving code out from
> the backend, and into the currentDB class? What I'm picturing in this case is
> reduce the backend more or less to to set and get functions, and leave all of
> the various rpm and filesystem logic up to the currentDB class.
>

Wonderful. Do it.

--
Hunter Matthews Unix / Network Administrator
Office: BioScience 145/244 Duke Univ. Biology Department
Key: F0F88438 / FFB5 34C0 B350 99A4 BB02 9779 A5DB 8B09 F0F8 8438
Never take candy from strangers. Especially on the internet.


--------------------​--------------------​--------------------​---------
To unsubscribe, e-mail: dev-unsubscribe@curr​ent.tigris.org
For additional commands, e-mail: dev-help at current dot tigris dot org

« Previous message in topic | 11 of 11 | Next message in topic »

Messages

Show all messages in topic

MySQL and other sql patch Frank Sweetser <fs at wpi dot edu> Frank Sweetser <fs at wpi dot edu> 2003-07-07 16:03:24 PDT
     Re: MySQL and other sql patch jwbernin John Berninger 2003-07-07 17:32:38 PDT
         Re: MySQL and other sql patch Frank Sweetser <fs at wpi dot edu> Frank Sweetser <fs at wpi dot edu> 2003-07-08 05:50:35 PDT
             Re: MySQL and other sql patch jwbernin John Berninger 2003-07-08 06:04:49 PDT
                 Re: MySQL and other sql patch Frank Sweetser <fs at wpi dot edu> Frank Sweetser <fs at wpi dot edu> 2003-07-08 06:12:06 PDT
                     Re: MySQL and other sql patch jwbernin John Berninger 2003-07-08 06:46:05 PDT
                     Re: MySQL and other sql patch hunterm Hunter Matthews 2003-07-08 09:26:44 PDT
                         Re: MySQL and other sql patch Frank Sweetser <fs at wpi dot edu> Frank Sweetser <fs at wpi dot edu> 2003-07-08 10:28:41 PDT
                             Re: MySQL and other sql patch hunterm Hunter Matthews 2003-07-23 13:49:08 PDT
                                 Re: MySQL and other sql patch Frank Sweetser <fs at WPI dot EDU> Frank Sweetser <fs at WPI dot EDU> 2003-07-23 13:51:48 PDT
             Re: MySQL and other sql patch Hunter Matthews <thm at duke dot edu> Hunter Matthews <thm at duke dot edu> 2003-07-08 09:23:08 PDT
Messages per page: