Login | Register
My pages Projects Community openCollabNet
Project highlights: Stable Version: 1.6.1, Development Version: 1.7.6

current
Reply to message

* = Required fields
* Subject
* Body
Attachments
Send reply to
Topic
Author (directly in email)
Please type the letters in the image above.

Original message

Author Frank Sweetser <fs@wpi.edu>
Full name Frank Sweetser <fs@wpi.edu>
Date 2003-07-08 05:50:35 PDT
Message On Mon, Jul 07, 2003 at 08:32:38PM -0400, John Berninger wrote:
> OK, here's my $0.02
>
> On Mon, 07 Jul 2003, Frank Sweetser wrote:
>
> > I've attached a patch which adds a new db_type, 'sql'. I started out by
> > just copying db/postgres/ and then hacked it up to work with either mysql
> > or postgresql based on a new config var, 'db_driver'. It should still work
> > just as before with postgresql, though I've only really tested it with
> > mysql so far.
> Uhhh.... no. I put the db_type variable in to distinguish
> between backends, not add another layer. I've got no problems with the
> concept of a MySQL backend, but it will be put in with a db_type of
> 'mysql' or something similar, not with a completely new config variable.

Fair enough. With the backend api, though, this would require a lot of code
duplication that's not db dependant. Would you object to moving code out from
the backend, and into the currentDB class? What I'm picturing in this case is
reduce the backend more or less to to set and get functions, and leave all of
the various rpm and filesystem logic up to the currentDB class.

...

> > Whadya think?
> Well, I'm forced to temper my thoughts due to the fact that
> there is a *major* problem with the DB schema as it exists at this
> time... the changes I'm going to have to make to fix this bug are going
> to be pretty extensive, and will probably end up breaking your code all
> to heck and back. I'll try to get something committed this week, but
> I'm way busier than I expected to be at this point, so no promises...

Okay - that shouldn't make much difference to the stuff I'm thinking of doing
as long as you don't depend upon any postgresql features that can't be faked
in mysql. I'll hold off on working on it until you get the schema stuff
straightened out, though.

--
Frank Sweetser fs at wpi.edu
WPI Network Engineer

--------------------​--------------------​--------------------​---------
To unsubscribe, e-mail: dev-unsubscribe@curr​ent.tigris.org
For additional commands, e-mail: dev-help at current dot tigris dot org