Login | Register
My pages Projects Community openCollabNet
Project highlights: Stable Version: 1.6.1, Development Version: 1.7.6

Reply to message

* = Required fields
* Subject
* Body
Send reply to
Author (directly in email)
Please type the letters in the image above.

Original message

Author jwbernin
Full name John Berninger
Date 2003-07-07 17:32:38 PDT
Message OK, here's my $0.02

On Mon, 07 Jul 2003, Frank Sweetser wrote:

> I've attached a patch which adds a new db_type, 'sql'. I started out by just
> copying db/postgres/ and then hacked it up to work with either mysql or
> postgresql based on a new config var, 'db_driver'. It should still work just
> as before with postgresql, though I've only really tested it with mysql so far.
        Uhhh.... no. I put the db_type variable in to distinguish
between backends, not add another layer. I've got no problems with the
concept of a MySQL backend, but it will be put in with a db_type of
'mysql' or something similar, not with a completely new config variable.

> In addition, it should make it pretty easy to add other sql drivers without too
> much copying of code.
        We've already got this capability - if there's similar code, it
should go into the "backend" base class.

> I only made minimal changes to the actual sql queries. The only bits I did
> really have to change were capitilization of table names (mysql is case
> sensetive, while it appears that postgresql is not) and a slightly differing
> distinct syntax.
        This is all good - mionimal changes are a good thing. :)

> Whadya think?
        Well, I'm forced to temper my thoughts due to the fact that
there is a *major* problem with the DB schema as it exists at this
time... the changes I'm going to have to make to fix this bug are going
to be pretty extensive, and will probably end up breaking your code all
to heck and back. I'll try to get something committed this week, but
I'm way busier than I expected to be at this point, so no promises...

John Berninger

GPG Key ID: A8C1D45C
        Fingerprint: B1BB 90CB 5314 3113 CF22 66AE 822D 42A8 A8C1 D45C

Sit vis nobiscum.

To unsubscribe, e-mail: dev-unsubscribe@curr​ent.tigris.org
For additional commands, e-mail: dev-help at current dot tigris dot org